Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of NotificationFailed #74

Closed
klimov-paul opened this issue Feb 13, 2020 · 3 comments
Closed

Remove usage of NotificationFailed #74

klimov-paul opened this issue Feb 13, 2020 · 3 comments

Comments

@klimov-paul
Copy link

Relates to #60.

I suppose usage of Illuminate\Notifications\Events\NotificationFailed event serves no purpose.
It complicates the source code without any significant outcome.

Class NotificationFailed is never used inside the Laravel Framework itself, despite it declares it.
It would be more consistent to drop its usage around this library.
@atymic
Copy link
Member

atymic commented Apr 19, 2020

See #90

@atymic atymic closed this as completed Apr 19, 2020
@atymic
Copy link
Member

atymic commented Apr 21, 2020

Released in v3 🎉
https://github.com/laravel-notification-channels/twilio/releases/tag/3.0.0

@clod986
Copy link

clod986 commented May 26, 2020

Still in TwilioChannel @ line61, is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klimov-paul @clod986 @atymic