fix: scrutinizer bugs

laravel-notification-channels · Apr 8, 2020 · 4a12b17 · 4a12b17
1 parent 356a032
commit 4a12b17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Twilio.php b/src/Twilio.php
@@ -82,7 +82,7 @@ protected function sendSmsMessage(TwilioSmsMessage $message, ?string $to): Messa
             $params['from'] = $from;
         }
 
-        if (! $from && ! $messagingServiceSid) {
+        if (empty($from) && empty($messagingServiceSid)) {
             throw CouldNotSendNotification::missingFrom();
         }
 

diff --git a/src/TwilioSmsMessage.php b/src/TwilioSmsMessage.php
@@ -50,7 +50,7 @@ public function getFrom(): ?string
             return $this->from;
         }
 
-        if ($this->alphaNumSender && $this->alphaNumSender !== '') {
+        if ($this->alphaNumSender !== null && $this->alphaNumSender !== '') {
             return $this->alphaNumSender;
         }
 
@@ -112,7 +112,7 @@ public function applicationSid(string $applicationSid): self
      * @param bool $forceDelivery
      * @return $this
      */
-    public function forceDelivery(string $forceDelivery): self
+    public function forceDelivery(bool $forceDelivery): self
     {
         $this->forceDelivery = $forceDelivery;