Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Attachments #34

Closed
ipshainu opened this issue Nov 7, 2017 · 7 comments
Closed

Using Attachments #34

ipshainu opened this issue Nov 7, 2017 · 7 comments

Comments

@ipshainu
Copy link

ipshainu commented Nov 7, 2017

Hi,

How can i attach images like ios_attachments and big_picture

@LKaemmerling
Copy link
Collaborator

You should be now able to set if with setParameter() in the next released version.

@AshPowell
Copy link
Contributor

@LKDevelopment @Lloople is it worth having a custom image/setImage function which would set all the image values... ie:

'ios_attachments' => ['id1' => $this->imageUrl], 'chrome_web_image' => $this->imageUrl, 'big_picture' => $this->imageUrl, 'adm_big_picture' => $this->imageUrl,

I'm aware there is now the new setParameter but I can see image being used frequently and with there being multiple values to set, would it make sense to have its own function?

@LKaemmerling
Copy link
Collaborator

LKaemmerling commented Jan 5, 2018

@AshPowell The Problem with a "One Function sets all Parameter" is, that if you want wo have only an image for chrome or different images for ios/android/chrome you can't set it with this function. So it would be configurabler to use the setParamter function.

@AshPowell
Copy link
Contributor

Fair point, would that ever be the case though? Typically you'd want the same values for each platform as the notification is the same... ie subject, body, icon all tend to be the same, I don't see why image wouldnt?

Worth an ask anyway :)

@Lloople
Copy link
Collaborator

Lloople commented Jan 5, 2018

Well, we can have a method called setImages for example which do the job to add all of them, and if you want different images then use the setParameter 🤔

@LKaemmerling
Copy link
Collaborator

Just in second i created the branch for setImage locally :)

@AshPowell
Copy link
Contributor

Excellent! It just makes it a little easier for something that will be a common function. (And now master has all the extra functionality my local extended version did, all is good :) )

@Lloople Lloople closed this as completed Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants