Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable it for php8.1 #143

Open
MuhammadSulman opened this issue May 30, 2022 · 2 comments
Open

Enable it for php8.1 #143

MuhammadSulman opened this issue May 30, 2022 · 2 comments

Comments

@MuhammadSulman
Copy link

It's not applicable for the php8.1 version
Selection_001
.

@robjbrain
Copy link

robjbrain commented Jun 23, 2022

You can easily create a fork for this.

I've already done it so you can skip steps 1-3 but for the sake of education I included it.

  1. Click "Fork" on github.
  2. Create a new branch called "fix-laravel9" (obviously can be anything)
  3. Edit composer.json to allow php8.1 and laravel 9
  4. Add this to your composer.json
"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/robjbrain/onesignal"
        }
    ],
"require": {
...
"laravel-notification-channels/onesignal": "dev-fix-laravel9"
}
  1. run composer update

Then it will work!

What this is doing is telling composer to look at the forked repo but still use the original name.

You have to use a different branch name and prefix it with "dev". I don't know why that is, presumably hard coded into composer in some way.

@teamappelit
Copy link

@robjbrain Thanks for your reply or time and for sharing your knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants