Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localisation of ExportNotification #47

Closed
mauthi opened this issue Mar 30, 2018 · 2 comments
Closed

Localisation of ExportNotification #47

mauthi opened this issue Mar 30, 2018 · 2 comments

Comments

@mauthi
Copy link
Contributor

mauthi commented Mar 30, 2018

This is a bug.

Description

There are some localisation things missing:

  • Notification text ('Export emailed: '.$this->name.' Table')
  • Subject of mail
  • BroadcastMessage? (export notification)
  • Mail Text is OK

Steps to Reproduce

Start a report
Start php artisan queue:work

Expected behavior

Text should be translateable

Actual behavior

Text is in english only
@aocneanu
Copy link
Member

Open a PR and add the __ where is missing. Probably ExportNotification.php

@mauthi
Copy link
Contributor Author

mauthi commented Mar 31, 2018

closed with #48

@mauthi mauthi closed this as completed Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mauthi @aocneanu