Update dependencies for Laravel 4.2

[dalabarge]

This includes my fixes from #176 and #144 (previously bexarcreativeinc-master branch)

[GrahamCampbell]

But why did you change the indentation to tabs? What's wrong with psr-2?

[dalabarge]

@GrahamCampbell I use 4-spaces in PHP projects much like the PSR-2 guide recommends. If you look at all the other code in this repository it uses tabs. I converted from spaces to tabs because @igorsantos07 wanted me to. My last update for Laravel 4.2 used spaces because my editor does it for me. I fixed that for compatibility with the rest of the code. If you want it all spaced to be PSR-2 compliant then I'd suggest that that be cared for in another PR.

[GrahamCampbell]

But this had spaces in it before you changed them? Why not just revert that here?

[dalabarge]

@GrahamCampbell There are tabs throughout this package in other files which I've never touched. PSR-2 compliance is a newer style-guide for this package and while I like it, that's not the point of this PR. If we want this entire package to be 4-spaced let's get this feature pulled in then let's submit a new PR that addresses that issue. At the moment this file is consistently tabbed.

[divdax]

Huh, any activity here? To work with Ardent on Laravel 4.2 pleeeease merge! 😄

[dalabarge]

As it turns out this repo is still not 4.2 compatible internally even with these changes. There are more fundamental incompatibilities between Laravel 4.2 and Ardent than just the above. I suggest you take a look at using https://github.com/dwightwatson/validating which uses traits (better) with Laravel 4.2 for validating. It's missing features that Ardent has such as purging, related models array, etc. however it's much better written and MIT licensed.

[divdax]

Thank you @dalabarge for the hint. Nice package!

[dalabarge]

@divdax and anyone else interested, there is now https://github.com/esensi/model which includes dwightwaton/validating package and provides nearly all the same functionality as Ardent but in a more maintainable way under MIT license and as traits.

[divdax]

Ok, now i definitely switch! That package is what i was waiting for. 😄 Thank you @dalabarge!

[igorsantos07]

@dalabarge any specific reason against BSD-3-Clause in favour of MIT License? I got curious on this :)
Also, why did you close this? Just gave up or are there other reasons?

[igorsantos07]

BTW It seems like we got that space/tabs issue again 😔

[igorsantos07]

And about the package versioning issue: if this is merged up it should be tagged as 3.0.0, since it need a whole new version of PHP that many users might not yet have (unfortunately, since they'd be quite late on this matter).

[dalabarge]

@igorsantos07 BSD-3 vs. MIT I suppose are very similar (I'm no lawyer mind you) though the BSD-3 license actually describes the terms vs. MIT which has universally the same terms. When working with client lawyers on code contracts, my lawyers advised to avoid using code that is GPL-licensed at all costs and use only MIT where possible.

As for why I closed the issue, it was very dormant and I'm not entirely sure is still compatible: there are lots of little changes in Eloquent. The Watson/Validating package and the Esensi/Model package are 4.2 compatible, MIT-licensed, and use traits (preferred) and include unit tests: so in a nut shell it's better (in my opinion) though it does require Laravel 4.2 and PHP 5.4. So Ardent or Magniloquent (which recommends Esensi/Model now for Laravel 4.2) are the best things for those looking for Laravel 4.1 and PHP 5.3 dependencies. I have no need for continuing development on those dependencies.

Regarding the tabs/spaces... I still don't understand what the specific problem here is (I honestly don't care either). I agree it should be entirely consistent throughout all source code in a package and for this I use .editorconfig file to ensure the IDEs comply. You might want to add it to this package.

I'll leave it open since you've reopened it but I won't be providing any further updates: sorry, it's just not something I can maintain when Esensi/Model exists. Maybe you'd like to devote your limited time (congrats and good luck with your studies, by the way) pointing other Ardent users to it and contributing updates to that project instead!?

I don't know what is "right" about versioning but what you want to avoid is that people automatically get upgraded through composer update and it then break. Most people should have a requirement of 2.4.* or ~2.4.2 and so you'll need to upgrade to 2.5.0 atleast to ensure the breaking changes aren't preventing PHP 5.3 users from continuing to do composer update. Thats said, anyone can simply lock the version to 2.4.2 though it requires a bit more debugging to figure that out so an update to the readme would be needed if 2.4.3 introduced a breaking change. I think a major update would require a major refactoring - not simply a dependency compatibility bump so 3.0.0 is not as appropriate as 2.5.0 but I'll let the internet confirm or deny this.

[chriskonnertz]

This branch is clearly out-dated and should be closed / rejected.