Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinearOperator adjoint tests could be improved #66

Closed
bwohlberg opened this issue Oct 26, 2021 · 0 comments · Fixed by #72
Closed

LinearOperator adjoint tests could be improved #66

bwohlberg opened this issue Oct 26, 2021 · 0 comments · Fixed by #72
Labels
enhancement New feature or request tests Pertaining to SCICO tests

Comments

@bwohlberg
Copy link
Collaborator

LinearOperator adjoint validity is currently tested using functions adjoint_AtA_test and adjoint_AAt_test in scico/test/linop/test_linop.py. It would be both more efficient and more reliable to replace these functions with a single function that takes the approach of sporco.linalg.valid_adjoint.
@bwohlberg bwohlberg added enhancement New feature or request tests Pertaining to SCICO tests labels Oct 26, 2021
@bwohlberg bwohlberg mentioned this issue Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests Pertaining to SCICO tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve LinearOperator adjoint tests lanl/scico
1 participant
@bwohlberg