Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No coherent policy on Operator parameter order #330

Open
bwohlberg opened this issue Sep 5, 2022 · 0 comments
Open

No coherent policy on Operator parameter order #330

bwohlberg opened this issue Sep 5, 2022 · 0 comments
Labels
discussion required Some discussion necessary to decide how to address this issue improvement Improvement of existing code, including addressing of omissions or inconsistencies

Comments

@bwohlberg
Copy link
Collaborator

Most LinearOperators tend to put operator-specific parameters first, but the ones constructed via linop_from_function put them after the standard input_shape parameter. This can be quite confusing, e.g. see current Pad vs Crop operator initialization.
@bwohlberg bwohlberg added discussion required Some discussion necessary to decide how to address this issue improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion required Some discussion necessary to decide how to address this issue improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwohlberg