Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfrastructureModels Conventions Maintenance #191

Closed
8 tasks done
ccoffrin opened this issue Jan 15, 2020 · 1 comment · Fixed by #194
Closed
8 tasks done

InfrastructureModels Conventions Maintenance #191

ccoffrin opened this issue Jan 15, 2020 · 1 comment · Fixed by #194

Comments

@ccoffrin
Copy link
Member

ccoffrin commented Jan 15, 2020

  • update to PowerModels v0.14
  • drop Manifest.toml from git and add to .gitignore
  • add "ResultCount" check in build_solution, otherwise JuMP.value() can fail (see PowerModels fix, lanl-ansi/PowerModels.jl@b80f4fe)
  • remove JuMP.optimize!, and merge code into optimize_model!
  • in optimize_model! make optimizer an optional kwarg (see, lanl-ansi/PowerModels.jl@8a8c9c0)
  • update core function names, build_model -> instantiate_model; build_solution -> build_result
  • update post_* functions to build_*
  • follow problem naming convention post_(mn_)<prob name>(_<variant>)*
@ccoffrin
Copy link
Member Author

Updates are in the travis-update-v2 and pms-v14 branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant