Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WORKFLOW_* configurable as environment variables. #8644

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

fujita-h
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Add configuration options for the workflow, including maximum execution steps, maximum execution time, and maximum call depth.

  • Added WORKFLOW_MAX_EXECUTION_STEPS=500
  • Added WORKFLOW_MAX_EXECUTION_TIME=1200
  • Added WORKFLOW_CALL_MAX_DEPTH=5

Fixes #8643

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Add configuration options for the workflow, including maximum execution steps, maximum execution time, and maximum call depth.

- Added WORKFLOW_MAX_EXECUTION_STEPS=500
- Added WORKFLOW_MAX_EXECUTION_TIME=1200
- Added WORKFLOW_CALL_MAX_DEPTH=5
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Sep 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@crazywoola crazywoola merged commit cae73b9 into langgenius:main Sep 23, 2024
6 checks passed
ZhouhaoJiang added a commit that referenced this pull request Sep 23, 2024
* main: (64 commits)
  chore: Enable Japanese descriptions for Tools (#8646)
  Make WORKFLOW_* configurable as environment variables. (#8644)
  feat: add deepseek-v2.5 for model provider siliconflow (#8639)
  docs: fix predefined_model_scale_out.md redirect error (#8633)
  feat: add qwen2.5 for model provider siliconflow (#8630)
  fix: send message error when chatting with opening statement (#8627)
  fix: llm_generator.py JSONDecodeError (#8504)
  fix: commands.py (#8483)
  fix: redundant check for available_document_count (#8491)
  chore: enhance configuration descriptions (#8624)
  chore: add Gemini newest experimental models (close #7121) (#8621)
  feat: support o1 series models for openrouter (#8358)
  fix: form input add tabIndex (#8478)
  Add model parameter translation (#8509)
  feat(tools/cogview):  Updated cogview tool to support cogview-3 and the latest cogview-3-plus (#8382)
  Add Fireworks AI as new model provider (#8428)
  feat:use xinference tts stream mode (#8616)
  docs: Add Japanese documentation for tools (#8469)
  feat: regenerate in `Chat`, `agent` and `Chatflow` app (#7661)
  feat: update pyproject.toml (#8368)
  ...
@fujita-h fujita-h deleted the add-workflow-env branch September 23, 2024 16:32
hgnulb pushed a commit to hgnulb/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make WORKFLOW_* configurable as environment variables.
2 participants