Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions in StackExchange Tool #3043

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

richards199999
Copy link
Contributor

@richards199999 richards199999 commented Mar 30, 2024

Description

I update the tool StackExchange YAML in order to let it work functionally.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested on local machine. And the tool works pretty well.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Mar 30, 2024
@Yeuoly
Copy link
Collaborator

Yeuoly commented Mar 30, 2024

Thanks, but there are few things can be optimized.

  1. order, sort and pagesize should be changed to form type instead of llm, as for now, it's not stable enough, it gives much freedom to LLM which may lead a bad result.
  2. filter is a constant value, but it's declared in yaml and has a llm type and was marked as required, it means that the LLM must reasoning a filter parameter from the query of user, however, you know, it's not necessary.

@richards199999
Copy link
Contributor Author

richards199999 commented Mar 31, 2024

for the first point, actually, i use the form type before, but i found that when choosing form type, user need to first type in the wanted number, it is pretty annoying; and i have tested llm form, the model would always use correct number.😁

and for the second point, yes you are right. and i have change it.🫡🫡

@Yeuoly
Copy link
Collaborator

Yeuoly commented Mar 31, 2024

for the first point, actually, i use the form type before, but i found that when choosing form type, user need to first type in the wanted number, it is pretty annoying; and i have tested llm form, the model would always use correct number.😁

and for the second point, yes you are right. but i'm not sure about how to do this.😢 i just need the value to be default as i intended to.

For the first one, you choose to use number or string as the type of your parameters and give a default value, such as pagesize: 5, sort: xxx, you can refer to bing.bing_search, what you want could be found there.

@crazywoola
Copy link
Member

Please fix the lint errors in ci builds.

@Yeuoly
Copy link
Collaborator

Yeuoly commented Apr 1, 2024

Sorry for that but could u pls rebase to main or merge main branch into your PR to fix the CI error, because there is a requirement update which results an error.

@crazywoola
Copy link
Member

@richards199999 There is a test needs to be fixed still. :)

@richards199999
Copy link
Contributor Author

richards199999 commented Apr 3, 2024 via email

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 5, 2024
@richards199999 richards199999 reopened this Apr 5, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 5, 2024
@richards199999
Copy link
Contributor Author

richards199999 commented Apr 6, 2024

Sure! I have approved the change now🫡

@Yeuoly
Copy link
Collaborator

Yeuoly commented Apr 7, 2024

Sure! I have approved the change now🫡

but have not modified yet?

@Yeuoly
Copy link
Collaborator

Yeuoly commented Apr 7, 2024

Sorry, what I mean is the type of the 2 fields should be select, not the descriptions.

@richards199999
Copy link
Contributor Author

@Yeuoly hope this update would be correct.🤗 apologize for the late, i have some school works to do these days🙏

@@ -0,0 +1,3 @@
{
"CodeGPT.apiKey": "Anthropic"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your perseverance and dedication, however, there is still a small change should be removed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i'm sorry this is not suppose to happen, let me fix this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the settings.json will make sense.

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@Yeuoly Yeuoly merged commit 16e3b04 into langgenius:main Apr 8, 2024
7 checks passed
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants