Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize helper for loading module from source #2862

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Mar 16, 2024

Description

  • generalize module_import_helper for loading module from source
  • it's used for avoid repeated code by
    • importing a module from the source file directly
      • Check, import and update the module name into sys.modules, according to Python docs Importing a source file directly
      • Support to use lazy import loader (disabled by default), which creates a real module object but is not loaded into memory, according to Implementing lazy imports. It may help to improve faster launch time and prevent actual loading unused modules (for LLM models, built-in tools, etc.), when it's turned on by default in the future.
    • getting subclasses of targeted parent type from the module

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@bowenliang123 bowenliang123 marked this pull request as ready for review March 16, 2024 15:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 16, 2024
@bowenliang123 bowenliang123 changed the title generalize module_import_helper for loading module from source generalize helper for loading module from source Mar 17, 2024
crazywoola
crazywoola previously approved these changes Mar 18, 2024
@dosubot dosubot bot added the lgtm label Mar 18, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some err happened when module loading

api/core/utils/module_import_helper.py Show resolved Hide resolved
@dosubot dosubot bot removed the lgtm label Mar 19, 2024
@bowenliang123 bowenliang123 marked this pull request as draft March 20, 2024 13:31
@bowenliang123 bowenliang123 marked this pull request as ready for review March 20, 2024 14:12
@bowenliang123
Copy link
Contributor Author

Tests added. Please review again.

Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm label Mar 28, 2024
@takatost takatost merged commit 08b7278 into langgenius:main Mar 28, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the load-module branch April 11, 2024 00:35
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants