Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump celery from 5.2 to 5.3 #2478

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Feb 19, 2024

Description

  • celery acts the backbone for async jobs in Dify and version 5.2 was released in Aug 2021
  • celery 5.3 release notes and history: https://docs.celeryq.dev/en/v5.3.6/changelog.html
  • no breaking changes
  • brings compatibility to Python 2.12 and sqlalchemy 2.x in its tests

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

  • tested locally by running the modules of API and worker, which depends on celery

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 19, 2024
crazywoola
crazywoola previously approved these changes Feb 20, 2024
@dosubot dosubot bot added the lgtm label Feb 20, 2024
takatost
takatost previously approved these changes Mar 28, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takatost takatost dismissed stale reviews from crazywoola and themself via e813b86 March 28, 2024 03:44
@takatost takatost merged commit 830495a into langgenius:main Mar 28, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the celery-5.3 branch May 8, 2024 07:57
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants