Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in human_in_the_loop.mdx after quatro processing #4360

Closed
jasonnathan opened this issue Feb 10, 2024 · 10 comments
Closed

Syntax error in human_in_the_loop.mdx after quatro processing #4360

jasonnathan opened this issue Feb 10, 2024 · 10 comments
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature

Comments

@jasonnathan
Copy link
Contributor

jasonnathan commented Feb 10, 2024

This is a bug in quatro. human_in_the_loop.ipynb is causing an error with the docs build. Somehow the correct syntax in the ipynb file:

import CodeBlock from "@theme/CodeBlock";
import HumanFeedback from "@examples/use_cases/human_in_the_loop/accept-feedback.ts";

is wrongly interpreted as:

import CodeBlock from “(**theme/CodeBlock?**)”; import HumanFeedback
from “(**examples/use_cases/human_in_the_loop/accept-feedback.ts?**)”;
Copy link

dosubot bot commented Feb 10, 2024

🤖

That's great to hear! Creating an issue is a good first step. Once you have the issue created, feel free to work on the PR and contribute your solution. Your contributions are valuable to the project!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Feb 10, 2024
@jasonnathan jasonnathan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
@jasonnathan jasonnathan reopened this Feb 10, 2024
@jasonnathan
Copy link
Contributor Author

I think in this one-off case, it would be simpler to just use examples/use_cases/human_in_the_loop/accept-feedback.ts content directly in the ipynb but if this is going to be common practice like other mdx files then it should be looked into

@jasonnathan jasonnathan changed the title Syntax error in human_in_the_loop.mdx Syntax error in human_in_the_loop.mdx after quatro processing Feb 10, 2024
@jacoblee93
Copy link
Collaborator

@bracesproul can you have a look?

@bracesproul
Copy link
Collaborator

Hmm this is weird.

How were you able to produce this? The builds are working fine in Vercel & locally (on my mac).

Are you running windows?

@jasonnathan
Copy link
Contributor Author

jasonnathan commented Feb 10, 2024

Nope Mac too. Happens right after quattro is done and the docs build fails.

I try yarn build from the root folder - which hardly works for me because of the order. Docs gets built with missing api_refs that's missing refs because other libs aren't built yet.

But thankfully it's cached so I just look out for the missing builds, build those then re-run the doc builds.

Past few times docs failed because of a syntax error. Fixed the previous one and now it's this

@jasonnathan
Copy link
Contributor Author

jasonnathan commented Feb 10, 2024

Just in case you hadn't noticed, that's a not a " as well and only for this one file

@jasonnathan
Copy link
Contributor Author

Maybe try without cache on your end?

@bracesproul
Copy link
Collaborator

Even with no cache I'm still unable to reproduce this error. There is a script which handles this bad quote ( ), are you sure your code is up to date with the latest main?

Also cc @jacoblee93 are you able to reproduce?

@cinqisap
Copy link
Contributor

cinqisap commented Mar 7, 2024

core_docs:build: SyntaxError: langchainjs/docs/core_docs/docs/use_cases/tool_use/human_in_the_loop.mdx: Unexpected character '“'. (1:22)
core_docs:build: > 1 | import CodeBlock from “(theme/CodeBlock?)”; import HumanFeedback
core_docs:build: | ^
core_docs:build: 2 | from “(examples/use_cases/human_in_the_loop/accept-feedback.ts?)”;
core_docs:build: [ERROR] Client bundle compiled with errors therefore further build is impossible.
core_docs:build: ERROR: command finished with error: command (langchainjs/docs/core_docs) yarn run build exited (1)

Hi, I also encountered the same issue when I installed quarto and run
yarn build --filter=core_docs under langchainjs/docs/

Could anyone tell me how to fix it?

Thanks

@jacoblee93
Copy link
Collaborator

I updated the docs build - can you pull main and try again? Reopen if it reoccurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants