-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Done: Implement SQLite RecordManager #4320
Comments
🤖 That's great to hear that you've implemented an SQLite RecordManager for the JS library! Opening an issue first is a good idea to discuss the proposed changes and gather feedback from the maintainers and the community. We encourage you to go ahead and open the issue, and once it's discussed and approved, you can proceed with creating the PR. Your contribution will be valuable to the repository. Keep up the good work! This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
@jacoblee93 okay to close this? The implementation is based on the existing PostgresRecordManager class. |
I will have a look today! Thank you! |
Are you thinking of adding indexing support to JS? |
Currently there is a postgres and memory implementation for RecordManager. While I was working on the chat_langchain repository, I noticed that the python version of ingest.py supports sqlite for a RecordManager so I implemented one in the JS library as well.
PR is ready, but wanted to open an issue first
The text was updated successfully, but these errors were encountered: