Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a flag to enable human input for Bedrock Agents #289

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

jdbaker01
Copy link
Collaborator

@jdbaker01 jdbaker01 commented Nov 22, 2024

  • Simplify the create of an agent which uses human input by including a flag (False by default to match current behavior).
  • Add new integration test for the use case.

@jdbaker01
Copy link
Collaborator Author

Will update, fixing lint.

@3coins 3coins changed the title Add flag for ask human as a tool. Added a flag to enable human input for Bedrock Agents Nov 23, 2024
Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaker01
This seems a bit different from the human confirmation input that your referenced in the documentation. The test sample you have included seems purely prompt based. Should the CONFIRM or DENY from the agent response be handled anywhere in the code?

@jdbaker01
Copy link
Collaborator Author

@jdbaker01 This seems a bit different from the human confirmation input that your referenced in the documentation. The test sample you have included seems purely prompt based. Should the CONFIRM or DENY from the agent response be handled anywhere in the code?

That is a different feature, this enables human input if the agent doesn’t have all the parameters. The confirm/deny is a separate issue and is “human confirmation”. Confirmations can be added to individual action whereas human input is applicable to all actions and is not confirm/deny but asks for missing params.

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaker01
Looks good!

@3coins 3coins merged commit f7dc810 into langchain-ai:main Dec 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants