Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChatBedrock to enable "test_stop_sequence" integration test #234

Open
3coins opened this issue Oct 10, 2024 · 3 comments
Open

Fix ChatBedrock to enable "test_stop_sequence" integration test #234

3coins opened this issue Oct 10, 2024 · 3 comments
Assignees
@Forma-Lin
Labels
bedrock bug Something isn't working
Milestone
v0.2.8

Comments

@3coins
Copy link
Collaborator

3coins commented Oct 10, 2024

Add stop attribute to ChatBedrock and ChatBedrockConverse classes to fix the standard "test_stop_sequence" integration tests.

tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_stop_sequence FAILED
tests/integration_tests/chat_models/test_standard.py::TestBedrockUseConverseStandard::test_stop_sequence FAILED
@3coins 3coins added bedrock maintenance bug Something isn't working and removed maintenance labels Oct 11, 2024
@3coins 3coins mentioned this issue Oct 11, 2024
Open
@3coins 3coins added this to the v0.2.5 milestone Oct 29, 2024
@Forma-Lin
Copy link

Hello @3coins, is anyone working on this issue right now? If no, may I take it?

@3coins
Copy link
Collaborator Author

3coins commented Nov 17, 2024

@Forma-Lin
Plz feel free to work on this. Let me know if I can help with anything to get you started. Assigned the issue to you.

@3coins 3coins modified the milestones: v0.2.7, v0.2.8 Nov 17, 2024
@zhaoJoseph zhaoJoseph mentioned this issue Nov 28, 2024
Open
@Forma-Lin
Copy link

@3coins
My teammate have submitted a PR, and want to kindly invite you to review it.
The PR address is: #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Forma-Lin Forma-Lin

Labels
bedrock bug Something isn't working
Projects
None yet
Milestone
v0.2.8
Development

No branches or pull requests
2 participants
@3coins @Forma-Lin