Wrap leave_module method in thread-safe manner #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running:
pylint --rcfile=dev-tools/pylint.rc -j 4 myapp
resulted in an overflow with:
...
I tracked this down to a race condition in the wrapping of the leave_module method, and this PR fixes that (there is still a race between different threads updating the method, but they no longer interfere with each other since the computation of the wrapped method is carefully guarded by the input to that computation being the original method)