Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 support #40

Closed
gitressa opened this issue Jun 22, 2022 · 8 comments
Closed

PHP 8.2 support #40

gitressa opened this issue Jun 22, 2022 · 8 comments

Comments

@gitressa
Copy link
Contributor

PHP 8.2 is coming, so it would be great if it got Lando support at some point.

@andypost
Copy link

There's official images to start with https://hub.docker.com/_/php?tab=tags&page=1&name=8.2

@gitressa
Copy link
Contributor Author

Perfect, thanks for sharing that info @andypost.

@allanlaal
Copy link

Lando worked great with PHP 8.1, so 8.2 won't require any fixes to run

@gitressa
Copy link
Contributor Author

If I set PHP to 8.2 in .lando.yml and start Lando I get an error.

.lando.yml

name: d10
recipe: drupal10
config:
  webroot: web
  php: '8.2'
$ lando start
Let's get this party started! Starting app d10...
ERROR ==> php version 8.2 is not supported message=php version 8.2 is not supported, stack=Error: php version 8.2 is not supported
    at new LandoCompose (/snapshot/cli/plugins/lando-core/compose/lando/builder.js)
    at new LandoAppserver (/snapshot/cli/plugins/lando-core/types/appserver/builder.js)
    at new LandoPhp (/snapshot/cli/node_modules/@lando/php/services/php/builder.js)
    at /snapshot/cli/plugins/lando-services/app.js
    at arrayEach (/snapshot/cli/node_modules/lodash/lodash.js:530:11)
    at Function.forEach (/snapshot/cli/node_modules/lodash/lodash.js:9410:14)
    at AsyncEvents.<anonymous> (/snapshot/cli/plugins/lando-services/app.js)
    at AsyncEvents.handle (/snapshot/cli/lib/events.js)
    at /snapshot/cli/lib/events.js
From previous event:
    at AsyncEvents.emit (/snapshot/cli/lib/events.js)
    at /snapshot/cli/lib/app.js
From previous event:
    at App.init (/snapshot/cli/lib/app.js)
    at initAndReport (/snapshot/cli/lib/app.js)
    at App.start (/snapshot/cli/lib/app.js)
    at Object.run (/snapshot/cli/plugins/lando-core/tasks/start.js)
From previous event:
    at /snapshot/cli/lib/cli.js
From previous event:
    at Object.handler (/snapshot/cli/lib/cli.js)
    at Object.runCommand (/snapshot/cli/node_modules/yargs/lib/command.js:238:44)
    at Object.parseArgs [as _parseArgs] (/snapshot/cli/node_modules/yargs/yargs.js:1063:30)
    at Function.get [as argv] (/snapshot/cli/node_modules/yargs/yargs.js:1004:21)
    at Cli.init (/snapshot/cli/lib/cli.js)
    at Cli.run (/snapshot/cli/lib/cli.js)
    at Object.<anonymous> (/snapshot/cli/bin/lando.js)
    at Module._compile (pkg/prelude/bootstrap.js:1794:22)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.runMain (pkg/prelude/bootstrap.js:1847:12)
    at internal/main/run_main_module.js:17:47, __stackCleaned__=true

██╗   ██╗██╗  ██╗     ██████╗ ██╗  ██╗██╗
██║   ██║██║  ██║    ██╔═══██╗██║  ██║██║
██║   ██║███████║    ██║   ██║███████║██║
██║   ██║██╔══██║    ██║   ██║██╔══██║╚═╝
╚██████╔╝██║  ██║    ╚██████╔╝██║  ██║██╗
 ╚═════╝ ╚═╝  ╚═╝     ╚═════╝ ╚═╝  ╚═╝╚═╝
                                         

An error occurred while starting up your app!
Here are a few things you can try to get back into a good state:

  ■ Try running lando rebuild
  ■ Try restarting in debug mode lando restart -vvv
  ■ Try checking the logs with lando logs

If those fail then consult the troubleshooting materials:

  ■ https://docs.lando.dev/help/logs.html
  ■ https://docs.lando.dev/help/updating.html

Or post your issue to Slack or GitHub

  ■ Slack - https://launchpass.com/devwithlando
  ■ GitHub - https://github.com/lando/lando/issues/new/choose

ERROR ==> php version 8.2 is not supported 

@kaszarobert
Copy link
Contributor

I started a PR #49
Please review if the Dockerfiles and other configurations are OK.

@reynoldsalec
Copy link
Member

...PHP 8.2 was added back in April, yay!

@andypost
Copy link

Now it's time for PHP 8.3 as rc5 is out

@kaszarobert
Copy link
Contributor

Let's solve 8.3 in a different issue: #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants