Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nbmake markers in notebook metadata #1996

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Sep 23, 2024

Description

This pull request updates the nbmake markers we use for the notebook tests that label certain notebooks as "slow". The markers are now in their own namespace. The markers used to be in the notebooks' metadata as,

"metadata": {
  "execution": {
    "markers": "slow"
  }
}

but are now,

"metadata": {
  "execution": {
    "nbmake": {
      "markers": "slow"
    }
  }
}

Checklist - did you ...

  • Add a news fragment file entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?
  • All tests have passed?
  • Formatted code with black?
  • Removed lint reported by flake8?
  • Sucessful documentation built? (if documentation added or modified)

@coveralls
Copy link

Coverage Status

coverage: 72.569% (-0.002%) from 72.571%
when pulling 9e0839e on mcflugen/update-nbmake-markers
into de0d762 on master.

@mcflugen mcflugen merged commit c8e7813 into master Sep 23, 2024
40 checks passed
@mcflugen mcflugen deleted the mcflugen/update-nbmake-markers branch September 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants