Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install with richdem even if it is not available #1379

Merged
merged 21 commits into from
Jan 20, 2022

Conversation

mcflugen
Copy link
Member

This pull request allows landlab to be installed even if the richdem package is not available, which, for now, means leaving out richdem for Python 3.10 on Windows. Users will be able to use the entirety of landlab except for the PriorityFloodFlowRouter.

We, ultimately, will want to fix richdem to work on all of landlab's supported platforms but this acts as a workaround until that time.

@mcflugen mcflugen requested a review from gregtucker January 19, 2022 22:08
@mcflugen mcflugen self-assigned this Jan 19, 2022
@mcflugen
Copy link
Member Author

In addition to fixing the issue with richdem, I've also fixed a related issue with the bmi-topography package (as seen in #1382, and #1381). As part of a previous pull request, bmi-topography was mistakenly added as a landlab requirement—although bmi-topography is used by a notebook tutorial, it's not used by landlab. Moving it from the requirements file to the notebook requirements file fixed the landlab installation issue but moved the same issue to notebook installation. The problem being that bmi-topography requires rasterio but rasterio is not available from PyPI for some platforms (namely, Windows).

With this pull request, landlab can now be installed with either pip (getting dependencies from PyPI) or conda (getting dependencies from conda-forge) but the requirements for the notebooks need to be installed using conda (for Windows, anyway).

mdpiper
mdpiper previously approved these changes Jan 20, 2022
.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants