Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discusion - Transform Serializer to be a singletone or use a Serializer singletone #73

Open
Unsigno opened this issue Jan 4, 2018 · 1 comment

Comments

@Unsigno
Copy link
Contributor

Unsigno commented Jan 4, 2018

I don't checked if there is a technical reason to don't do it , but this should be more simple and representative . So we don't need to keep and pass the serializer instances .

@OpherV
Copy link
Member

OpherV commented Jan 22, 2018

In a way it's already a singleton, just not very explicit. I don't have an issue with it being a singleton to clean up the API a bit on both the client and the server.
PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants