Fix error message on setter with wrong type #20444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
reviewed
May 21, 2024
| @@ -1334,12 +1334,9 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer | |||
|
|
|||
| val setter = toSetter(lhsCore) | |||
| if setter.isEmpty then reassignmentToVal | |||
There was a problem hiding this comment.
When can setter actually be empty? We haven't found any such cases.
There was a problem hiding this comment.
When the pattern match in toSetter gets to the default case. But I am not sure this is ever the case. On the other hand, programs with parse errors can give uncommon trees, so better be defensive.
|
Test failure: The check file for i20338b seems to be incorrect. |
Co-authored-by: Matt Bovel<[email protected]> Co-authored-by: Nicolas Stucki<> Co-authored-by: Hamza Remmal<> Co-authored-by: Mehdi Alaoui<> fix check file
odersky
approved these changes
May 23, 2024
| @@ -1334,12 +1334,9 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer | |||
|
|
|||
| val setter = toSetter(lhsCore) | |||
| if setter.isEmpty then reassignmentToVal | |||
There was a problem hiding this comment.
When the pattern match in toSetter gets to the default case. But I am not sure this is ever the case. On the other hand, programs with parse errors can give uncommon trees, so better be defensive.
WojciechMazur
added a commit
that referenced
this pull request
Jul 9, 2024
Backports #20444 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20338
Poke @mbovel @nicolasstucki @hamzaremmal @AnotherMedo