Various fixes to stdlib-cc #19873
Merged
Various fixes to stdlib-cc #19873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the failing tests are reduced to: 33 suites passed, 3 failed, 36 total
tests/neg/syntax-error-recovery.scala failed
tests/neg/multi-file-error failed
tests/run/enrich-gentraversable.scala failed
tests/run/enrich-gentraversable.scala failedThe first two seem to be a problem in my local setup. So there should be one last issue remaining. |
| * The helper method [[seqViewIsSeq_]] is added to make the binary compatible. | ||
| */ | ||
| @annotation.targetName("seqViewIsSeq") | ||
| def seqViewIsSeq_[CC0[X] <: SeqView[X], A0]: IsSeq[CC0[A0]] { type A = A0; type C = View[A0] } = ??? |
There was a problem hiding this comment.
Suggested change
| def seqViewIsSeq_[CC0[X] <: SeqView[X], A0]: IsSeq[CC0[A0]] { type A = A0; type C = View[A0] } = ??? | |
| @annotation.publicInBinary | |
| private[IsSeq] def seqViewIsSeq_[CC0[X] <: SeqView[X], A0]: IsSeq[CC0[A0]] { type A = A0; type C = View[A0] } = ??? |
odersky
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19819, fixes #19652, fixes #19847, supersedes #19858