Improve error message when using experimental definitions #19782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
nicolasstucki
force-pushed
the
improve-feedback-of-experimental-error-message
branch
from
3ad054c to
ed991f5
Compare
odersky
reviewed
Feb 27, 2024
tests/neg/use-experimental-def.check
Outdated
| 7 |def bar: Int = foo // error | ||
| | ^^^ | ||
| | Experimental definition may only be used under experimental mode: | ||
| | 1. In a definition marked as @experimental |
There was a problem hiding this comment.
We can make that clearer like this:
Experimental definition may only be used under experimental mode:
| 1. in a definition marked as @experimental, or
| 2. compiling with the -experimental compiler flag, or
| 3. with a nightly or snapshot version of the compiler.
Otherwise it could also be interpreted as "and".
nicolasstucki
force-pushed
the
improve-feedback-of-experimental-error-message
branch
from
ed991f5 to
76f6c6e
Compare
When an experimental definition is used, the error message shows how to enable the experimental mode. Previously we only did this for experimental language features, but not for experimental definitions.
nicolasstucki
force-pushed
the
improve-feedback-of-experimental-error-message
branch
from
76f6c6e to
89d6104
Compare
odersky
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an experimental definition is used, the error message shows how to enable the experimental mode. Previously we only did this for experimental language features, but not for experimental definitions.