Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent crash when extension not found #18830

Merged
merged 1 commit into from
Nov 3, 2023
Merged

prevent crash when extension not found #18830

merged 1 commit into from
Nov 3, 2023

Conversation

bishabosha
Copy link
Member

found when entering expression Tuple(1) into repl, if I made TastyHeaderUnpickler always throw an exception, so maybe there are other situations where this could occur.

@bishabosha bishabosha requested a review from odersky November 2, 2023 17:02
@bishabosha bishabosha mentioned this pull request Nov 2, 2023
Merged
@bishabosha bishabosha requested a review from sjrd November 3, 2023 15:43
@sjrd sjrd merged commit 9453cb1 into scala:main Nov 3, 2023
18 checks passed
@sjrd sjrd deleted the fix-minor-crash-implicits branch November 3, 2023 16:00
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

@odersky odersky Awaiting requested review from odersky

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bishabosha @sjrd @Kordyjan