Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #11967: flow typing nullability in pattern matches #18212

Merged
merged 2 commits into from
Oct 1, 2023
Merged

fix #11967: flow typing nullability in pattern matches #18212

merged 2 commits into from
Oct 1, 2023

Conversation

olhotak
Copy link
Contributor

@olhotak olhotak commented Jul 14, 2023 •
edited
Loading

Fixes #11967

@olhotak olhotak requested review from odersky and noti0na1 July 14, 2023 21:11
@olhotak olhotak self-assigned this Jul 14, 2023
noti0na1
noti0na1 approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

compiler/src/dotty/tools/dotc/typer/Typer.scala Show resolved Hide resolved
tests/explicit-nulls/pos/flow-match.scala Show resolved Hide resolved
@noti0na1 noti0na1 mentioned this pull request Jul 19, 2023
Merged
@odersky odersky merged commit ac5fcfb into main Oct 1, 2023
@odersky odersky deleted the fix-11967 branch October 1, 2023 15:31
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

@olhotak olhotak

Labels
area:nullability
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Null checks with pattern matching are not reflected to the return type with -Yexplicit-nulls
4 participants
@olhotak @odersky @noti0na1 @Kordyjan