Fix #16675 : -Wunused false positive on case class generated method, due to flags used to distinguish case accessors.
#16683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix flag confusion between (case)accessor and (potentially) generated method in classes - Update test suits. Add test from scala#16675
PaulCoral
force-pushed
the
fix/Wunused/flags_for_class
branch
from
85f545b
to
2ffab1d
Compare
PaulCoral
changed the title
-Wunused false positive on case class generated method, due to flags used to distinguish case accessors.
szymon-rd
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@szymon-rd This fixes #16675. This add more flags checks on symbol to distinguish generated method and various accessors generated by case classes
DONE