Stabilize new lazy vals #16614
Stabilize new lazy vals #16614
Conversation
| @@ -45,7 +45,7 @@ class CompilationTests { | |||
| compileFilesInDir("tests/pos-custom-args/erased", defaultOptions.and("-language:experimental.erasedDefinitions")), | |||
| compileFilesInDir("tests/pos", defaultOptions.and("-Ysafe-init")), | |||
| // Run tests for experimental lightweight lazy vals | |||
| compileFilesInDir("tests/pos", defaultOptions.and("-Ysafe-init", "-Ylightweight-lazy-vals", "-Ycheck-constraint-deps"), FileFilter.include(TestSources.posLazyValsAllowlist)), | |||
| compileFilesInDir("tests/pos", defaultOptions.and("-Ysafe-init", "-Ylegacy-lazy-vals", "-Ycheck-constraint-deps"), FileFilter.include(TestSources.posLazyValsAllowlist)), | |||
There was a problem hiding this comment.
Update the comment above.
Also would we now want to run all the pos and run tests instead of just the ones from the lists?
There was a problem hiding this comment.
I think that no, we still want to run these tests, but now for legacy instead of the new lazy vals. New lazy vals will be now tested in standard pos and run tests. But the comment should be updated ofc.
| object Evaluating extends LazyValControlState | ||
|
|
||
| /** |
There was a problem hiding this comment.
Wasn't the comment supposed to stay?
| @@ -0,0 +1 @@ | |||
| -Ylegacy-lazy-vals | |||
There was a problem hiding this comment.
Do we really need that? I thought .flag files in tests are deprecated and vulpix doesn't even take them into consideration
There was a problem hiding this comment.
It does work, the generated code differs. Mainly because the previous PR on lazy vals implemented .flag files for printing tests 😄 Is it the direction we are taking - to deprecate .flag files?
Resolve #16555