Avoid stackoverflow in ExplicitOuter #16381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transforming a class at ExplicitOuter we create outer accessors for it. The newSymbol call to do this takes place at phase ExplicitOuter + 1, but its arguments need to be evaluated at phase ExplicitOuter. This was not true for the nestingLevel argument, which demanded the denotation of the class at phase ExplicitOuter + 1, thus leading to the SO. Interestingly, the same path is not taken if the class has all abstract members defined or is declared abstract. It's only in the error case that I could reproduce the SO.
smarter
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transforming a class at ExplicitOuter we create outer accessors for it. The newSymbol call to do this takes place at phase ExplicitOuter + 1, but its arguments need to be evaluated at phase ExplicitOuter. This was not true for the nestingLevel argument, which demanded the denotation of the class at phase ExplicitOuter + 1, thus leading to the SO.
Interestingly, the same path is not taken if the class has all abstract members defined or is declared abstract. It's only in the error case that I could reproduce the SO.
Fixes #16343