Support inline unapplySeq and with leading given parameters #16358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-15191
branch
from
5fc9776 to
4646e10
Compare
nicolasstucki
force-pushed
the
fix-15191
branch
2 times, most recently
from
6cbb190 to
ee5283f
Compare
nicolasstucki
changed the title
nicolasstucki
changed the title
smarter
reviewed
Nov 18, 2022
| case TypeApply(_, targs) => targs | ||
| case _ => Nil | ||
| val unapplyInfo = sym.info match | ||
| case info: PolyType => info.instantiate(targs.map(_.tpe)) |
There was a problem hiding this comment.
Why isn't this needed anymore? The comment above could maybe explain how type parameters are handled.
There was a problem hiding this comment.
That's handled by fun.tpe.widen (line 202)
There was a problem hiding this comment.
I added a comment below and managed to simplify the leading implicits logic thanks to the use of fun.tpe.widen.
Now it even works with something as complex as
extension [T] (using A)(inline ctx: Macro.StrCtx)(using B) inline def unapplySeq[U](using C)(inline input: T)(using D)(using F): Option[Seq[T]] = ???
* Fixes the computation of the inline unapply temporary unanimous unapply placeholder * Handle leading given parameters in inline unapplies Fixes scala#8577 Fixes scala#12991 Fixes scala#15188
nicolasstucki
force-pushed
the
fix-15191
branch
from
ee5283f to
3b1d780
Compare
smarter
approved these changes
Dec 7, 2022
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #15191 by @gorilskij and enables support for #12991.
Fixes #8577
Fixes #12991
Fixes #15188