-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fewerBraces a standard feature #16297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
added
the
needs-minor-release
This PR cannot be merged until the next minor release
label
Nov 7, 2022
Enables fewerBraces as a standard feature from 3.3 on. No language import is needed.
odersky
force-pushed
the
std-fewer-braces
branch
from
November 8, 2022 07:34
a881354
to
43e3b7c
Compare
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, following up in the scalameta.
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
tgodzik
added a commit
to tgodzik/scalameta
that referenced
this pull request
Nov 8, 2022
Follow up from scala/scala3#16297
kitbellew
pushed a commit
to scalameta/scalameta
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables fewerBraces as a standard feature from 3.3 on. No language import is needed.
The old
is deprecated but it still works. This is so that one can continue to mix fewerBraces in for projects compiling with earlier versions. We can turn the language import into a no-op or drop it completely when 3.3 is in the rear mirror.