Fix ValDef span assignment in PatternMatcher #15783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15535
Problem was in
ValDef
creation inPatternMatcher
.When the following code
gets transformed to
there are new
ValDef
s created forx1
andy
. Theirspan
s are assigned byPositioned.envelope
based on spans ofValDef
's fields. Those spans not always exist. In that case, span is assigned inseq
function based on span of the block, which is usually incorrect.Solution is to set
ValDef
'sspan
to thespan
of originalTermSymbol
from which current val is being created.