Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing condition in checking synthetic apply #15362

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Add missing condition in checking synthetic apply #15362

merged 2 commits into from
Jun 3, 2022

Conversation

liufengyun
Copy link
Contributor

Add missing condition in checking synthetic apply

@liufengyun liufengyun requested a review from olhotak June 3, 2022 05:52
olhotak
olhotak approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

compiler/src/dotty/tools/dotc/transform/init/Semantic.scala Show resolved Hide resolved
@olhotak olhotak merged commit 05396b4 into scala:main Jun 3, 2022
@olhotak olhotak deleted the add-missing-condition branch June 3, 2022 12:21
odersky added a commit to dotty-staging/dotty that referenced this pull request Jun 5, 2022
@odersky
Handle Range cases when reducing match types
0b7c599 
Fixes scala#15362
@odersky odersky mentioned this pull request Jun 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liufengyun @olhotak