Disallow old uses of quoted and spliced types #15012
Conversation
nicolasstucki
added
the
needs-minor-release
There was a problem hiding this comment.
-
If we change this, we need to change
syntax.md(both versions) as well. -
Currently, in syntax.md I find
paren ::= ‘(’ | ‘)’ | ‘[’ | ‘]’ | ‘{’ | ‘}’ | ‘'(’ | ‘'[’ | ‘'{’That's wrong. isn't it?
'{and friends are two tokens, or not? In that case we need to change this part as well. -
I am not sure what the motivation for the change is. If we do use
'[ ... ]in patterns, would it not be more general to allow it in types as well?
We do not really change anything in this PR, we are just disallowing the use of syntax that was already deprecated in 3.0.0. This allows us to check the use of this syntax directly into the parser. This refactor makes |
nicolasstucki
force-pushed
the
tighten-quoted-and-spliced-types
branch
from
459e47d to
8ae971f
Compare
nicolasstucki
force-pushed
the
tighten-quoted-and-spliced-types
branch
from
8ae971f to
15a1321
Compare
|
rebased |
|
needs another rebase |
These have have been emitting migration warning in 3.0 and 3.1 even if the syntax was already deprecated in 3.0. These where allowed syntax found in older papers. The case `'[T]` was actually buggy but no one reported this bug so far. A good indication that this older syntax has not been used in a while. First step towards fixing scala#15009.
Now that we do not support the old syntax for splicing types it is not possible to get this error. The code is buggy and fails with another error that is not worth testing.
nicolasstucki
force-pushed
the
tighten-quoted-and-spliced-types
branch
from
15a1321 to
9306274
Compare
|
rebased and fixed conflict in |
These have have been emitting migration warning in 3.0 and 3.1 even if the
syntax was already deprecated in 3.0. These where allowed syntax found
in older papers.
The case
'[T]was actually buggy but no one reported this bug so far.A good indication that this older syntax has not been used in a while.
First step towards fixing #15009.