Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor language imports when unpickling #14962

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Honor language imports when unpickling #14962

merged 3 commits into from
Apr 19, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 18, 2022 •
edited
Loading

Fixes #14947

@odersky odersky changed the title Honor language imports mode when unpickling Honor language imports when unpickling Apr 18, 2022
@odersky odersky requested a review from noti0na1 April 18, 2022 12:42
noti0na1
noti0na1 requested changes Apr 18, 2022
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you copy the test to tests/explicit-nulls/pos-special as well, and add the pickling test flags?

@noti0na1 noti0na1 assigned odersky and unassigned noti0na1 Apr 18, 2022
@odersky odersky assigned noti0na1 and unassigned odersky Apr 18, 2022
@noti0na1
Copy link
Member

Hi,

I tried this fix, but it does not work when the unsafeNulls import is inside a function:

class C {
  def g: String | Null = ???

  def f =
    import scala.language.unsafeNulls
    if true then "" else g
}

noti0na1
noti0na1 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! LGTM

@noti0na1 noti0na1 merged commit dcb0d15 into scala:main Apr 19, 2022
@noti0na1 noti0na1 deleted the fix-14947 branch April 19, 2022 17:12
@bishabosha bishabosha mentioned this pull request Apr 19, 2022
Open
@noti0na1 noti0na1 mentioned this pull request May 3, 2022
Closed
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

Assignees

@noti0na1 noti0na1

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Pickling difference error with explicit nulls and unsafe nulls
3 participants
@odersky @noti0na1 @Kordyjan