Also hoist lifted arguments in super calls #14919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super calls with default and named parameters can have lifted arguments in val defs preceding the constructor call. If these are complex, we need to hoist them out as well. Fixes scala#14164
|
Where can we find the jsunit test's source that fails? It seems to be really well hidden. I search of all of GitHub for NestedJSClassTest turned up nothing. |
|
Thanks, that was the area I was in. Sorry I didn't get back to it. Oh, I see my local dotty is still spitting out "needs hoist" messages. |
Since we never housted arguments if the supercall had lifted parameters, we did not exercise that case before. Some fixes were necessary to make it work.
dwijnand
reviewed
Apr 16, 2022
dwijnand
approved these changes
Apr 16, 2022
|
I did not manage to update it. I don't really know how these tests are
supposed to work.
…On Sat, Apr 16, 2022 at 11:02 AM Dale Wijnand ***@***.***> wrote:
***@***.**** approved this pull request.
If that proves too hard, I'm fine with dropping it.
—
Reply to this email directly, view it on GitHub
<#14919 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCKVSU2R7ZH2U2KKSIE63VFJ63PANCNFSM5TJ2LD2Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Martin Odersky
Professor, Programming Methods Group (LAMP)
Faculty IC, EPFL
Station 14, Lausanne, Switzerland
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super calls with default and named parameters can have
lifted arguments in val defs preceding the constructor call.
If these are complex, we need to hoist them out as well.
Fixes #14164