Fix #14773: Reuse the param slots for the tailrec local mutable vars. #14865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tailrec phase generates code that looks like
This generates bytecode where the
this
value and the parameters never actually change, and are never used. Instead, the synthetic mutable variables are used instead.As described in the linked issue, this confuses debuggers, which only display the never-changing original
this
value and parameters.In this commit, we intercept this shape of code in the back-end. We reliable identify tailrec-generated
ValDef
s from their semantic names, with an additional safety check that they areSynthetic | Mutable
. When we find this shape, we do not allocate local slots for thevar
s, and instead reuse the slots forthis
and the parameters. We skip past theValDef
s so that code generation does not re-emit useless assignments.