Allow non-hot values in SeqLiterals

[Xavientois]

Closes #14460, #14751

Do not ensure that elements in a SeqLiteral are Hot.

Review by @liufengyun

[Xavientois]

@liufengyun @olhotak I have not yet implemented the parametricity solution we discussed, as this change appears to solve all of the enum cases we were looking at (Array.apply and AnyRef).

This currently passes all of the enum test cases, but fails three neg tests:

• tests/init/neg/scodec.scala
• tests/init/neg/early-promote.scala
• tests/init/neg/leak-warm.scala

Since we want List.apply to allow cold arguments, it looks like leak-warm should no longer cause an error.

I am less certain about the desired behaviour for the other two tests. Should they still trigger an error?

[liufengyun]

Thanks Josh!

I am less certain about the desired behaviour for the other two tests. Should they still trigger an error?

For SeqLiterals, we need to return a join of the argument values instead of Hot. The current change simply skips the check of argument values, thus it is problematic.

[Xavientois]

For SeqLiterals, we need to return a join of the argument values instead of Hot. The current change simply skips the check of argument values, thus it is problematic.

I think I may have originally misunderstood. What do you mean by the join of the values? Should I try to promote them?

[liufengyun]

For SeqLiterals, we need to return a join of the argument values instead of Hot. The current change simply skips the check of argument values, thus it is problematic.

I think I may have originally misunderstood. What do you mean by the join of the values? Should I try to promote them?

I mean you can return Result(ress.map(_.value).join, ress.flatMap(_.errors)). The logic in call will take care of the promotion check.

[liufengyun]

LGTM

[olhotak]

LGTM. There's a merge conflict in a .check file that needs to be resolved.