-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better utilizing GADT bounds for HKTs #13323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linyxus
commented
Aug 25, 2021
@abgruszecki Hey Alex, I have finished the modification. Also, I add some additional code to allow the LHS HKT to be approximated to its GADT upper bound. |
Linyxus
changed the title
Better utilizing GADT lower bounds for HKTs
Better utilizing GADT bounds for HKTs
Aug 29, 2021
abgruszecki
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the nitpick, the PR LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13257. Before this PR, the following code example could not compile:
It is sound to allow its compilation, since
Int <: Const[A] <: F[A]
. This PR changes the TypeComparer's behavior by trying to approximate the type constructor when GADT bounds is available. A global state is added to the TypeComparer to track whether HKT bounds have been used during type comparison, to properly handle the injectivity conditions.