Stabilize Symbol member methods in reflection API #13314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
stabilize-refelection-symbol-members-api
branch
2 times, most recently
from
b132fd6
to
fadf978
Compare
smarter
reviewed
Aug 18, 2021
smarter
reviewed
Aug 18, 2021
dwijnand
changed the title
nicolasstucki
force-pushed
the
stabilize-refelection-symbol-members-api
branch
from
fadf978
to
821a0e3
Compare
nicolasstucki
force-pushed
the
stabilize-refelection-symbol-members-api
branch
from
bf35a48
to
88764c5
Compare
smarter
reviewed
Aug 20, 2021
| def memberMethod(name: String): List[Symbol] | ||
|
|
||
| /** Get named non-private methods declared or inherited */ | ||
| @experimental | ||
| def methodMember(name: String): List[Symbol] |
There was a problem hiding this comment.
Why do both methodMember and methodMembers return a List[Symbol] ? Shouldn't methodMember return a Symbol?
There was a problem hiding this comment.
Those are the overloads
smarter
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.