Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Context leak in deffered Annotation tree #13301

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

dos65
Copy link
Contributor

@dos65 dos65 commented Aug 16, 2021

Previously, readLaterWithOwner captured the initial context in lambda
that contributed in memory leak problems when compiler is used from IDE

Previously, `readLaterWithOwner` captured the initial context in lambda
that contributed in memory leak problems when compiler is used from IDE
@prolativ prolativ requested a review from odersky August 16, 2021 16:59
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@odersky odersky merged commit 1520ef0 into scala:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants