Fetch Inkuire at scaladoc build instead of documentation generation #13287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
force-pushed
the
scaladoc/scaladoc-offline-generation
branch
from
049ffae
to
5fd6ce7
Compare
smarter
approved these changes
Aug 12, 2021
project/Build.scala
Outdated
| import _root_.scala.sys.process._ | ||
| import _root_.scala.concurrent._ | ||
| import ExecutionContext.Implicits.global | ||
| val inkuireLink = "https://github.com/VirtusLab/Inkuire/releases/download/1.0.0-M2/inkuire.js" |
There was a problem hiding this comment.
Could you extract 1.0.0-M2 into an inkuireVersion val?
pikinier20
force-pushed
the
scaladoc/scaladoc-offline-generation
branch
from
5fd6ce7
to
a5affd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13272
sbt doesn't provide an API for downloading files from internet so I need to use scala.sys.process. However, the process didn't timeout if the machine was offline so I wrapped that in Future and await result for 20s. I think it's enough considering the file size is 1mb.