[SemanticDB]Support new Scala3 modifiers in SemanticDB #13239
Conversation
now we distinguish implicit and given in SemanticDB - Proposal to add new properties to SemanticDB schema - scalameta/scalameta#2439 - Generated scala code copied from - tanishiking/semanticdb-for-scala3#2
tanishiking
changed the title
| @@ -429,7 +429,7 @@ class ExtractSemanticDB extends Phase: | |||
| props |= SymbolInformation.Property.FINAL.value | |||
| if sym.is(Sealed) then | |||
| props |= SymbolInformation.Property.SEALED.value | |||
| if sym.isOneOf(GivenOrImplicit) then | |||
There was a problem hiding this comment.
It might be better to keep implicit property for givens for backward compatibility, and remove it may be in the next minor version release of Scala3?
(Or we can go because I suppose there are quite a few consumers for this information: probably only metals? and it's controllable)
There was a problem hiding this comment.
We tried that already, but it turned out that it was overall simplest the way it is now.
| @@ -935,7 +935,7 @@ _empty_/Enums.Suits.Clubs. => case val static enum method Clubs | |||
| _empty_/Enums.Suits.Diamonds. => case val static enum method Diamonds | |||
| _empty_/Enums.Suits.Hearts. => case val static enum method Hearts | |||
| _empty_/Enums.Suits.Spades. => case val static enum method Spades | |||
| _empty_/Enums.Suits.derived$CanEqual. => implicit lazy val method derived$CanEqual | |||
| _empty_/Enums.Suits.derived$CanEqual. => lazy val given method derived$CanEqual | |||
There was a problem hiding this comment.
Is this really given? Can they be lazy?
| _empty_/Enums.Suits.derived$CanEqual. => lazy val given method derived$CanEqual | |
| _empty_/Enums.Suits.derived$CanEqual. => lazy val given method derived$CanEqual |
There was a problem hiding this comment.
Yes, this is actually Given. This symbol is automatically generated given value by drives CanEqual
enum Suits derives CanEqual:
case Hearts, Spades, Clubs, Diamonds
// `drives CanEuqual` will automatically generate given instance something like
lazy given val derived$CanEqual: CanEqual[Enums.Suits, Enums.Suits] =
CanEqual.derivedhttps://dotty.epfl.ch/docs/reference/contextual/derivation.html
There was a problem hiding this comment.
Yes, parameterless givens are mapped to lazyvals by default. Some of them are mapped to defs when we can prove that that does not change semantics, so that we can omit generating a field.
| @@ -429,7 +429,7 @@ class ExtractSemanticDB extends Phase: | |||
| props |= SymbolInformation.Property.FINAL.value | |||
| if sym.is(Sealed) then | |||
| props |= SymbolInformation.Property.SEALED.value | |||
| if sym.isOneOf(GivenOrImplicit) then | |||
There was a problem hiding this comment.
We tried that already, but it turned out that it was overall simplest the way it is now.
| @@ -935,7 +935,7 @@ _empty_/Enums.Suits.Clubs. => case val static enum method Clubs | |||
| _empty_/Enums.Suits.Diamonds. => case val static enum method Diamonds | |||
| _empty_/Enums.Suits.Hearts. => case val static enum method Hearts | |||
| _empty_/Enums.Suits.Spades. => case val static enum method Spades | |||
| _empty_/Enums.Suits.derived$CanEqual. => implicit lazy val method derived$CanEqual | |||
| _empty_/Enums.Suits.derived$CanEqual. => lazy val given method derived$CanEqual | |||
There was a problem hiding this comment.
Yes, parameterless givens are mapped to lazyvals by default. Some of them are mapped to defs when we can prove that that does not change semantics, so that we can omit generating a field.
Now we distinguish
implicitandgivenin SemanticDB.It might be better to wait merging until scalameta/scalameta#2439 has merged.