Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hole a proper Tree in Trees #13213

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 30, 2021

This is the first step into making the Hole trees Ycheckable.
To YCheck them we need an untyped version of the tree.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jul 30, 2021

Adds first cleanup staps needed for #12540

@nicolasstucki nicolasstucki marked this pull request as ready for review July 30, 2021 11:05
@smarter
Copy link
Member

smarter commented Jul 30, 2021

Can you explain the context for this PR? This just moves a class to a different location right?

@nicolasstucki
Copy link
Contributor Author

This is the first step to make Hole Ycheckable. Right now we generate the holes and immediately pickle them. The idea is that I will add the holes one phase earlier and this way the three can be checked. This will require re-typechecking which means we will need an untyped version of Hole.

This just moves the definition to form some lost corner of pickling into Trees. The next steps will be added afterward in #12540 or by themselfs.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, please put that information in the commit message :).

This is a first step into making the Hole trees Ycheckable.
To YCheck them we need an untyped version of the tree.
@nicolasstucki nicolasstucki merged commit 038cc73 into scala:master Aug 3, 2021
@nicolasstucki nicolasstucki deleted the cleanup-definition-of-hole branch August 3, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants