Handle overloaded members when generating Java varargs bridges #13066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Jul 15, 2021
Comment on lines
+85
to
+86
| * but that does not work, since `allOverriddenSymbols` gets confused because the | ||
| * signatures of a Java varargs method and a Scala varargs override are not the same. |
There was a problem hiding this comment.
The issue is that allOverriddenSymbols delegates to Denotation#matchingDenotation which is missing the logic present in Denotation#matchesLoosely to handle matching denotations across languages (java/scala2/scala3), I think this needs to be fixed but this is a good stop-gap meanwhile.
TheElectronWill
approved these changes
Jul 15, 2021
| @@ -85,7 +102,8 @@ class ElimRepeated extends MiniPhase with InfoTransformer { thisPhase => | |||
| private def isVarargsMethod(sym: Symbol)(using Context) = | |||
| hasVarargsAnnotation(sym) || | |||
| hasRepeatedParams(sym) && | |||
| (sym.allOverriddenSymbols.exists(s => s.is(JavaDefined) || hasVarargsAnnotation(s))) | |||
| overridesJava(sym) | |||
There was a problem hiding this comment.
The previous version skipped the checks on overriden symbols when there were no repeated params (hence the parens). Is it intentional to change that?
There was a problem hiding this comment.
No, this is missing a pair of parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13043