Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines should not be stripped from #define statements #5

Closed
mikecao opened this issue Aug 29, 2016 · 3 comments
Closed

Newlines should not be stripped from #define statements #5

mikecao opened this issue Aug 29, 2016 · 3 comments

Comments

@mikecao
Copy link

mikecao commented Aug 29, 2016

If you tell the parser to strip newlines but have code like this:

#define SOMEVALUE 1
uniform vec3 color;

You'll end up with:

#define SOMVALUE1uniform vec3 color;

Great work on this project by the way 👍

@lammas
Copy link
Owner

lammas commented Aug 29, 2016

Thanks, this means a lot.
This hasn't really been used as a minifier yet, I'll see what I can do about this.

@lammas lammas closed this as completed in 2a77f4e Aug 29, 2016
@lammas
Copy link
Owner

lammas commented Aug 29, 2016

Hopefully this works, because I could not reproduce the part with the missing spaces.

@mikecao
Copy link
Author

mikecao commented Aug 29, 2016

Works perfectly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants