Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Refactor ln.track() to improve logging and method signature #2176

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Nov 14, 2024

Logging

Create transform uid

Transform key does not yet exist

Before:

>>> ln.track()
β†’ notebook imports: lamindb==0.76.13
β†’ to track this notebook, copy & paste `ln.track("TSGPgRifmwuX0000")` and re-run

After:

>>> ln.track()
β†’ to track this notebook, run: ln.track("TSGPgRifmwuX0000")

Transform key already exists

Before:

>>> ln.track()
β†’ notebook imports: lamindb==0.76.13
β†’ you already have a transform with key 'test-cross-instance.ipynb' ('Szhz8MJz9g4J0000')
  - to make a revision, call `ln.track('Szhz8MJz9g4J0001')`
  - to create a new transform, rename your file and run: `ln.track()`

After:

>>> ln.track()
β†’ you already have a transform with key 'test-cross-instance.ipynb': Transform('Szhz8MJz')
  (1) to make a revision, run: ln.track("Szhz8MJz9g4J0001")
  (2) to create a new transform, rename your notebook file and re-run: ln.track()

Track transform run

Before:

>>> ln.track("Szhz8MJz9g4J0000")
β†’ notebook imports: lamindb==0.76.13
β†’ loaded Transform('Szhz8MJz'), started Run('oMNgTZ6q') at 2024-11-14 20:10:11 UTC

After:

>>> ln.track("Szhz8MJz9g4J0000")
β†’ loaded Transform('Szhz8MJz'), started Run('oMNgTZ6q') at 2024-11-14 20:03:16 UTC
β†’ notebook imports: lamindb==0.76.13

Method signature

Before After
image image

Materials

Needs:

Resolves:

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.63%. Comparing base (c90d140) to head (df12a69).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2176   +/-   ##
=======================================
  Coverage   92.62%   92.63%           
=======================================
  Files          54       54           
  Lines        6512     6519    +7     
=======================================
+ Hits         6032     6039    +7     
  Misses        480      480           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 14, 2024

@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 20:20 Inactive
@falexwolf falexwolf changed the title 🚸 Refactor ln.track() 🚸 Refactor ln.track() to improve logging and method signature Nov 14, 2024
@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 20:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 14, 2024 22:24 Inactive
@falexwolf falexwolf merged commit b71b666 into main Nov 14, 2024
16 checks passed
@falexwolf falexwolf deleted the track branch November 14, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚸 Do not show notebook package version information if no uid is present
1 participant