Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Make source code searchable #1855

Merged
merged 21 commits into from
Sep 3, 2024
Merged

🚸 Make source code searchable #1855

merged 21 commits into from
Sep 3, 2024

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Aug 27, 2024

This change enables searchability of source code both on the hub and in lamindb by treating source code in the same way as metadata (say ontology descriptions). transform.source_code gets stored in a Text column in Postgres/SQLite. By all realistic calculations, this will never lead to scalability issues.

Also, we're now

  • using the py:percent format for notebooks for a cleaner representation of transform.source_code
  • stripping the notebook title both from run reports and source code to de-duplicate with the transform.name field (so that these can no longer get out-of-sync)

Needs:

Comes with:

Internal Slack discussion.

@falexwolf falexwolf changed the title 🚸 Store source code in the database rather than in storage 🚸 Make source code searchable Aug 27, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.29%. Comparing base (5096bb0) to head (45fb3f7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/_finish.py 96.66% 2 Missing ⚠️
lamindb/core/_context.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1855   +/-   ##
=======================================
  Coverage   92.28%   92.29%           
=======================================
  Files          52       52           
  Lines        5938     5970   +32     
=======================================
+ Hits         5480     5510   +30     
- Misses        458      460    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 31, 2024

@github-actions github-actions bot temporarily deployed to pull request August 31, 2024 21:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2024 22:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2024 23:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2024 23:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 17:07 Inactive
@falexwolf falexwolf merged commit c719aab into main Sep 3, 2024
15 checks passed
@github-actions github-actions bot temporarily deployed to pull request September 3, 2024 19:59 Inactive
@falexwolf falexwolf deleted the sourcecode branch September 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant