-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Make source code searchable #1855
Merged
Merged
+118
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
🚸 Store source code in the database rather than in storage
🚸 Make source code searchable
Aug 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1855 +/- ##
=======================================
Coverage 92.28% 92.29%
=======================================
Files 52 52
Lines 5938 5970 +32
=======================================
+ Hits 5480 5510 +30
- Misses 458 460 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables searchability of source code both on the hub and in lamindb by treating source code in the same way as metadata (say ontology descriptions).
transform.source_code
gets stored in aText
column in Postgres/SQLite. By all realistic calculations, this will never lead to scalability issues.Also, we're now
py:percent
format for notebooks for a cleaner representation oftransform.source_code
transform.name
field (so that these can no longer get out-of-sync)Needs:
Comes with:
Internal Slack discussion.