-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate module configuration cache via command line #5
Comments
@roelvanduijnhoven module config generally is applied with any CLI command execution (due to it caching-style transparent API), so a "hello world" action in your app should be sufficient in order to generate all cache config. Another issue about this is that the CWD must match in order for many configs to actually work as expected. Originally posted by @Ocramius at zendframework/zend-modulemanager#54 (comment) |
Mm. True. Config depending on Maybe close this one; and properly fix locking. Originally posted by @roelvanduijnhoven at zendframework/zend-modulemanager#54 (comment) |
Agree that they shouldn't do that 😥. Maybe a validation CLI command that verifies generated config is On 17 Feb 2017 1:42 p.m., "Roel van Duijnhoven" [email protected] Mm. True. Config depending on $_SERVER will break for example. And although Maybe close this one; and properly fix locking. — Reply to this email directly, view it on GitHub Originally posted by @Ocramius at zendframework/zend-modulemanager#54 (comment) |
If you use a timestamp as a cache key somewhere in your configuration; you get two config files that are not idempotent. But that is a valid usecase, right? So idempotent is not important IMO. The thing is that the config generated via CLI should work on web in an ideal world. But I am almost sure that this won't be true in a lot of real-world use cases. If you really want to warm up your cache you should expose an end-point on the web; that will trigger the config generation. But that is outside of the scope of this repo, right? Originally posted by @roelvanduijnhoven at zendframework/zend-modulemanager#54 (comment) |
It is EXTREMELY important, because that already shows that you can't cache config.
That's where the validation would simply make the generator crash. It wouldn't prevent the user from caching configs, but at least it would say "You're on your own, buddy! You're doing things that I don't want to be held responsible for.".
Yes, that's out of scope and it also opens a can of worms when it comes to security issues (DDoS related, specifically) Originally posted by @Ocramius at zendframework/zend-modulemanager#54 (comment) |
Related to PR zendframework/zend-modulemanager#53.
On a production running website one would ideally have the
module-config-cache.php
file generated before launching a new version. It would help if a command line utility would exist for this. This could work like the autoloader could be generated beforehand: https://framework.zend.com/manual/2.2/en/modules/zend.loader.classmap-generator.html.Any thoughts on this?
Originally posted by @roelvanduijnhoven at zendframework/zend-modulemanager#54
The text was updated successfully, but these errors were encountered: